Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates for CPP low level hits #848

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

updates for CPP low level hits #848

wants to merge 4 commits into from

Conversation

sdobbs
Copy link
Contributor

@sdobbs sdobbs commented Oct 23, 2024

  • add handling of writing out all the appropriate fields for FMWPC hits to HDDM event format
  • add ability to apply thresholds to both the digit hit amplitude and integral. we can implement the appropriate CCDB table after this

@gluex
Copy link

gluex commented Oct 23, 2024

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/tests/summary.txt
Logs: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/tests/log

Build log: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/make_sdobbs_fmwpc_fix_oct2024.log
Build report: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/report_sdobbs_fmwpc_fix_oct2024.txt
Location of build: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024

@aaust
Copy link
Contributor

aaust commented Oct 24, 2024

I tried to write out events with randomtrigger_skim from a CPP evio file, and I get these entries:

      <fmwpcChamber layer="6" wire="77">
          <fmwpcHit dE="0" t="184">
            <fmwpcHitQ q="0" />
            <fmwpcHitQ q="1194" />
            <fmwpcDigiHit amp="0" ped="0" qf="0" />
          </fmwpcHit>
        </fmwpcChamber>
        <fmwpcChamber layer="6" wire="78">
          <fmwpcHit dE="0" t="340.8">
            <fmwpcHitQ q="0" />
            <fmwpcHitQ q="1663" />
            <fmwpcDigiHit amp="0" ped="0" qf="0" />
          </fmwpcHit>
        </fmwpcChamber>

For comparison, the master produces this:

        <fmwpcChamber layer="6" wire="77">
          <fmwpcHit dE="0" t="184">
          </fmwpcHit>
        </fmwpcChamber>
        <fmwpcChamber layer="6" wire="78">
          <fmwpcHit dE="0" t="340.8">
          </fmwpcHit>
        </fmwpcChamber>

Do you understand why HitQ is written out twice, once with 0 value? And why are all digihit entries 0?

@aaust
Copy link
Contributor

aaust commented Nov 6, 2024

@sdobbs Did you have any more insights on this?

@sdobbs
Copy link
Contributor Author

sdobbs commented Nov 6, 2024

Thanks for the reminder on this, I will take a look.

@gluex
Copy link

gluex commented Dec 6, 2024

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/make_sdobbs_fmwpc_fix_oct2024.log
Build report: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/report_sdobbs_fmwpc_fix_oct2024.txt
Location of build: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024

@gluex
Copy link

gluex commented Dec 6, 2024

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/make_sdobbs_fmwpc_fix_oct2024.log
Build report: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/report_sdobbs_fmwpc_fix_oct2024.txt
Location of build: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024

@sdobbs
Copy link
Contributor Author

sdobbs commented Dec 6, 2024 •
edited
Loading

This should be working now - I had some bad function calls in my previous implementation.

Let me see why the build tests aren't even running.

@gluex
Copy link

gluex commented Dec 6, 2024

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/make_sdobbs_fmwpc_fix_oct2024.log
Build report: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/report_sdobbs_fmwpc_fix_oct2024.txt
Location of build: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024

@sdobbs
Copy link
Contributor Author

sdobbs commented Dec 6, 2024

some of it is that we are missing the nightly build...

@gluex
Copy link

gluex commented Dec 6, 2024

Build status for this pull request: FAILURE

Build log: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/make_sdobbs_fmwpc_fix_oct2024.log
Build report: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/report_sdobbs_fmwpc_fix_oct2024.txt
Location of build: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024

@sdobbs
Copy link
Contributor Author

sdobbs commented Dec 6, 2024

ok yeah, my guess is that there is some issues with the disks mounted on the machine where these tests/builds are running

@aaust
Copy link
Contributor

aaust commented Dec 11, 2024

You are right, the mapping of the disks was in a weird state. After it was fixed, I redid the nightly build.

@aaust aaust closed this Dec 11, 2024
@aaust
Copy link
Contributor

aaust commented Dec 11, 2024

Reopen to restart test.

@aaust aaust reopened this Dec 11, 2024
@gluex
Copy link

gluex commented Dec 11, 2024

Test status for this pull request: SUCCESS

Summary: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/tests/summary.txt
Logs: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/tests/log

Build log: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/make_sdobbs_fmwpc_fix_oct2024.log
Build report: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024/report_sdobbs_fmwpc_fix_oct2024.txt
Location of build: /work/halld/pull_request_test/halld_recon^sdobbs_fmwpc_fix_oct2024

@aaust
Copy link
Contributor

aaust commented Dec 11, 2024

Great, that looks better:

      <forwardMWPC>
        <fmwpcChamber layer="4" wire="66">
          <fmwpcHit dE="0" t="476">
            <fmwpcHitQ q="1284" />
            <fmwpcDigiHit amp="179" ped="187" qf="0" />
          </fmwpcHit>
        </fmwpcChamber>
        <fmwpcChamber layer="4" wire="67">
          <fmwpcHit dE="0" t="372">
            <fmwpcHitQ q="1414" />
            <fmwpcDigiHit amp="93" ped="202" qf="0" />
          </fmwpcHit>
        </fmwpcChamber>
      </forwardMWPC>

instead of

     <forwardMWPC>
        <fmwpcChamber layer="4" wire="66">
          <fmwpcHit dE="0" t="476">
          </fmwpcHit>
        </fmwpcChamber>
        <fmwpcChamber layer="4" wire="67">
          <fmwpcHit dE="0" t="372">
          </fmwpcHit>
        </fmwpcChamber>
      </forwardMWPC>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdobbs @gluex @aaust